Fixed nullability attributes generation on .NET Standard targets#4168
Merged
michael-hawker merged 5 commits intoCommunityToolkit:mainfrom Aug 13, 2021
Merged
Conversation
Sergio0694
added
bug 🐛
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
UnitTests/UnitTests.NetCore/Mvvm/Test_INotifyPropertyChangedAttribute.cs
Outdated
Show resolved
Hide resolved
UnitTests/UnitTests.NetStandard/SampleModelWithINPCAndObservableProperties.cs
Outdated
Show resolved
Hide resolved
michael-hawker
approved these changes
Aug 12, 2021
XAML-Knight
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4167
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Build error due to unusable attributes when using
[INotifyPropertyChanged]on .NET Standard 2.0.What is the new behavior?
No build errors, attributes are generated as expected when needed.
PR Checklist
Please check if your PR fulfills the following requirements: